Require modern onion #5058
Merged
Require modern onion #5058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
added
the
protocol
rustyrussell
force-pushed
the
guilt/require-modern-onion
branch
2 times, most recently
from
9340143
to
2f97762
Compare
cdecker
force-pushed
the
guilt/require-modern-onion
branch
from
2f97762
to
7b2a62f
Compare
|
Rebased on top of ACK 7b2a62f |
We're about to drop support for legacy. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
I thought about fixing them up, but really these should be in lnprototest anyway. Turns out they're from the spec, so we should actually fix them up there. I moved the vector files into contrib/pyln-proto, since that still needs them. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
As per proposal in lightning/bolts#962 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Removed: protocol: support for legacy onion format removed, since everyone supports the new one.
rustyrussell
force-pushed
the
guilt/require-modern-onion
branch
from
7b2a62f
to
4334d36
Compare
|
Ack 4334d36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements lightning/bolts#962
Removes a great deal of code. Nice!